Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xgcalendar.js #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update xgcalendar.js #27

wants to merge 1 commit into from

Conversation

Vence
Copy link

@Vence Vence commented Jul 9, 2015

支持农历日期及节日
增加农历日历扩展,在day数字的右边显示节日或节气,同时也可以修改为显示农历日期,本修改可以继续扩展节日,节日分类农历和公历节日。

增加农历日历扩展,在day数字的右边显示节日或节气,同时也可以修改为显示农历日期,本修改可以继续扩展节日,节日分类农历和公历节日。
@xuanye
Copy link
Owner

xuanye commented Jul 9, 2015

我认为节日和农历应该使用数据的方式展现 而不是在组件本身

@Vence
Copy link
Author

Vence commented Jul 9, 2015

这种方式可以实现,我在我的项目中用到你的类库,每条日程我都希望点击打开能够展示出详情,并且还有日程的动态,日程的附件,日程的参与人等等。日程和节日的处理方式毕竟不同,如果把节日看成日程的话,那么是否就要加标志去做区分;虽然我目前将节日放在了组件中,不过如果有时间我觉得可以这样做,节日还是数据,不过组件里需要添加一个句柄去把节日传进去,显示在指定的位置,不等同于日程,我觉得这样做比较好,也就是说组件中必须要对节日做成特殊的渲染

@nirgal
Copy link
Contributor

nirgal commented Jun 12, 2017

Maybe xgcalendar should not show locale-specific data.
I am not sure this has a lot of meaning outside of China...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants