Use Conductor Analytics card #23
Conversation
| @@ -0,0 +1,620 @@ | |||
| define("app/application", | |||
There was a problem hiding this comment.
this should likely define something more specific.
define("conductor/analytics/card/application") or something
There was a problem hiding this comment.
Confirm. This code lives inside the iframe, so there's no risk of conflict for the moment, but I agree, this isn't a great module name.
There was a problem hiding this comment.
this card might be a good test-bed for inline-adapter / pure-adapter card.
|
Awesome. I am excited. I left some inline comments. One holistic thing i noticed, was that you build an namespace, depend on the namespace, and do lots of the stitching yourself. EAK or something like EAK would eleviate most of these concerns, and likely improve developer happiness. If EAK is deficient in some way, let me know and we should work together to resolve that deficiency. |
|
@cyril-sf got a chance to rebase ? |
|
@stefanpenner I'm taking a look at it now |
|
@cyril-sf thanks dude. |
|
@stefanpenner I've updated the code, feel free to let me know if you have any issues with it. I didn't get the chance of using EAK yet on this project (but on another one). |
No description provided.