-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For ALP][Don't merge now] Support corosync3/kronosnet #108
Open
liangxin1300
wants to merge
49
commits into
yast:master
Choose a base branch
from
liangxin1300:20230623_for_corosync3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e75a7f0.
This reverts commit 0876c9a.
Add: system, resources, nozzle sub-directive Remove: qb sub-directive Change: timestamp default values Modify read/write of totem to generic method.
Only support write 1 interface. Only support add node section one by one. Fix write of logger_subsys section. Fix a bug with dict merge, should always go with .update() Note: ag_openais ready
Support multiple interfaces instead of only one.
1. Remove dummy write to logging section.
Set key to :interface_list Del, otherwise "l" will be used in cluster
Without a corosync.conf, yast will read /etc/corosync.conf.example In the example file, node without IP configured in node list. Should draw in UI instead of save in memory only.
Need assign node name when multiple links instead of knet.
Fix broken UI when adding without existed linknumber. Initialize knet transport.
The interface sub-directive of totem is optional for UDP and knet transports. For knet, multiple interface subsections define parameters for each knet link on the system. For UDPU an interface section is not needed and it is recommended that the nodelist is used to define cluster nodes. So, unicast should disable/drop interface list. Multicast should drop knet_transport and knet_link_priority. Kronosnet should drop bindnetaddr/mcastaddr/mcastport.
1. Change "Bind Address" to "Bind Net Addr", unified the labels of interface list table. 2. Immediate show warning when no Node ID of Kronosnet mode. 3. Enhance the comment of name in nodelist directive.
…ue to correct place. The checker is from corosync exec/totemconfig.c if ((strcmp(tmp_cipher, "none") != 0) && (strcmp(tmp_hash, "none") == 0)) { *error_string = "crypto_cipher requires crypto_hash with value other than none"; res = -1; goto out_free_crypto_model_str; }
e07b7e5
to
8169307
Compare
And remove unused codes
Corresponding no 'clear_node_high_bit' in corosync.conf Due to the man corosync.conf, cluster behavior is undefined if this option enabled
- Remove 'Cluster.config_format' - Remove 'memberaddr'
50a5f3b
to
ae7101f
Compare
ae7101f
to
dff84f7
Compare
dff84f7
to
ef29354
Compare
Note Before MergingThis PR is for corosync3, which is incompatible with corosync2. So, if the next step for the master branch is for 15SP6(which should still keep with corosync2), we should consider submitting this PR to another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note Before Merging
This PR is for corosync3, which is incompatible with corosync2. So, if the next step for the master branch is for 15SP6(which should still keep with corosync2), we should consider submitting this PR to another branch
Major changes:
Screenshots
Test rpm
(remember all libknet1-* packages should be installed)