Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For ALP][Don't merge now] Support corosync3/kronosnet #108

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

liangxin1300
Copy link
Contributor

@liangxin1300 liangxin1300 commented Jun 21, 2023

Note Before Merging

This PR is for corosync3, which is incompatible with corosync2. So, if the next step for the master branch is for 15SP6(which should still keep with corosync2), we should consider submitting this PR to another branch

Major changes:

  • Support corosync3/kronosnet
  • Totem UI change for node list and interface list
  • Enhance validations for input
  • Use 'black' to re-format Python file ag_corosync
  • Bump version to 5.0.0

Screenshots

Screenshot from 2023-07-06 11-35-50

Test rpm

liangxin1300 and others added 30 commits June 20, 2023 21:55
Add:
	system, resources, nozzle sub-directive
Remove:
	qb sub-directive
Change:
	timestamp default values

Modify read/write of totem to generic method.
Only support write 1 interface.
Only support add node section one by one.
Fix write of logger_subsys section.
Fix a bug with dict merge, should always go with .update()

Note: ag_openais ready
Support multiple interfaces instead of only one.
1. Remove dummy write to logging section.
Set key to :interface_list Del, otherwise "l" will be used in cluster
Without a corosync.conf, yast will read /etc/corosync.conf.example
In the example file, node without IP configured in node list.

Should draw in UI instead of save in memory only.
Need assign node name when multiple links instead of knet.
Fix broken UI when adding without existed linknumber.
Initialize knet transport.
The interface sub-directive of totem is optional for UDP and knet transports.
For knet, multiple interface subsections define parameters for each knet
link on the system.
For UDPU an interface section is not needed and it is recommended that the
nodelist is used to define cluster nodes.

So, unicast should disable/drop interface list.
Multicast should drop knet_transport and knet_link_priority.
Kronosnet should drop bindnetaddr/mcastaddr/mcastport.
1. Change "Bind Address" to "Bind Net Addr", unified the labels
  of interface list table.
2. Immediate show warning when no Node ID of Kronosnet mode.
3. Enhance the comment of name in nodelist directive.
…ue to correct place.

The checker is from corosync exec/totemconfig.c
    if ((strcmp(tmp_cipher, "none") != 0) &&
        (strcmp(tmp_hash, "none") == 0)) {
        *error_string = "crypto_cipher requires crypto_hash with
             value other than none";
        res = -1;

        goto out_free_crypto_model_str;
    }
@liangxin1300 liangxin1300 force-pushed the 20230623_for_corosync3 branch 8 times, most recently from e07b7e5 to 8169307 Compare July 6, 2023 07:59
@liangxin1300 liangxin1300 force-pushed the 20230623_for_corosync3 branch 3 times, most recently from 50a5f3b to ae7101f Compare July 7, 2023 14:01
@liangxin1300 liangxin1300 force-pushed the 20230623_for_corosync3 branch from ae7101f to dff84f7 Compare July 10, 2023 09:08
@liangxin1300 liangxin1300 changed the title [WIP] support corosync3/kronosnet Support corosync3/kronosnet Jul 10, 2023
@liangxin1300 liangxin1300 marked this pull request as ready for review July 10, 2023 09:20
@liangxin1300 liangxin1300 force-pushed the 20230623_for_corosync3 branch from dff84f7 to ef29354 Compare July 10, 2023 10:17
@liangxin1300
Copy link
Contributor Author

Note Before Merging

This PR is for corosync3, which is incompatible with corosync2. So, if the next step for the master branch is for 15SP6(which should still keep with corosync2), we should consider submitting this PR to another branch

@liangxin1300 liangxin1300 changed the title Support corosync3/kronosnet [For ALP][Don't merge now] Support corosync3/kronosnet Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants