Don't Block in AutoYaST Upgrade with Reboot Message [SLE-15-SP5]

[shundhammer]

Target Branch

This is for SLE-15-SP5. A merge to SLE-15-SP6, -SP7 and master / Factory will follow.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1181625

Trello

https://trello.com/c/jxGwssL6/

Problem

In certain situations, an AutoYaST upgrade may block with a pop-up dialog "The system will reboot now" message that does not continue after a timeout as it should; the user needs to confirm it interactively which is against the idea of an auto-upgrade.

Cause

The pop-up is suppressed only in Mode.autoinst, not also in Mode.autoupgrade.

Fix

Instead of just checking for Mode.autoinst, check for Mode.auto which includes both Mode.autoinst and Mode.autoupgrade.

See also https://github.com/yast/yast-yast2/blob/master/library/general/src/modules/Mode.rb#L283-L286

Related PRs

• Merge to SLE-15-SP6: Don't Block in AutoYaST Upgrade with Reboot Message [SLE-15-SP6] #1120
• Merge to SLE-15-SP7: Not needed, this was done implicitly when SLE-15-SP7 was branched off SP6
• Merge to master / Factory: Don't Block in AutoYaST Upgrade with Reboot Message [master] #1123

[coveralls]

coverage: 40.913%. remained the same
when pulling 38b7553 on huha-ay-upgrade-sp5
into ecc4aeb on SLE-15-SP5.

[yast-bot]

✔️ Internal Jenkins job #759 successfully finished
✔️ Created IBS submit request #342269