Eliminate mutants

yiisoft · Oct 18, 2024 · 84dc464 · 84dc464
1 parent 7d2334e
commit 84dc464
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/tests/Paginator/OffsetPaginatorTest.php b/tests/Paginator/OffsetPaginatorTest.php
@@ -529,8 +529,9 @@ public function testImmutability(): void
     public static function dataIsSupportSorting(): array
     {
         return [
-            [true, new IterableDataReader([])],
-            [false, new StubOffsetData()],
+            'IterableDataReader' => [true, new IterableDataReader([])],
+            'StubOffsetData' => [false, new StubOffsetData()],
+            'StubOffsetDataWithLimit' => [false, (new StubOffsetData())->withLimit(10)],
         ];
     }
 

diff --git a/tests/Support/StubOffsetData.php b/tests/Support/StubOffsetData.php
@@ -15,6 +15,12 @@ final class StubOffsetData implements
     CountableDataInterface,
     LimitableDataInterface
 {
+    /**
+     * @var int|null
+     * @psalm-var non-negative-int
+     */
+    private ?int $limit = null;
+
     public function read(): iterable
     {
         return [];
@@ -32,7 +38,9 @@ public function count(): int
 
     public function withLimit(?int $limit): static
     {
-        return $this;
+        $new = clone $this;
+        $new->limit = $limit;
+        return $new;
     }
 
     public function withOffset(int $offset): static
@@ -42,7 +50,7 @@ public function withOffset(int $offset): static
 
     public function getLimit(): ?int
     {
-        return 0;
+        return $this->limit;
     }
 
     public function getOffset(): int