Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #175: Add testcase for multibyte LikeHandler #190

Merged
merged 6 commits into from
Sep 8, 2024
Merged

Fix #175: Add testcase for multibyte LikeHandler #190

merged 6 commits into from
Sep 8, 2024

Conversation

samdark
Copy link
Member

@samdark samdark commented Sep 7, 2024

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

@samdark samdark requested a review from arogachev September 7, 2024 16:03
@arogachev arogachev added the type:enhancement Enhancement label Sep 7, 2024
@arogachev arogachev added this to the 1.1 milestone Sep 7, 2024
@arogachev arogachev linked an issue Sep 7, 2024 that may be closed by this pull request
Find a test case with multibyte strings for Like filter handler #175
Closed
vjik
vjik requested changes Sep 7, 2024
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a line in changelog

@samdark
Copy link
Member Author

samdark commented Sep 7, 2024 •
edited
Loading

There's no change for end user at all so I doubt changelog is needed.

@samdark
Copy link
Member Author

samdark commented Sep 8, 2024

Added CHANGELOG.

vjik
vjik approved these changes Sep 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
arogachev and others added 2 commits September 8, 2024 14:57
@arogachev @vjik
Update CHANGELOG.md
6c23fa1 
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@arogachev
Merge branch 'master' into 175-add-testcase-mb
a2bf1bc
@arogachev arogachev merged commit 5f7cc68 into master Sep 8, 2024
16 of 17 checks passed
@arogachev arogachev deleted the 175-add-testcase-mb branch September 8, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

@arogachev arogachev arogachev approved these changes

Assignees
No one assigned
Labels
type:enhancement Enhancement
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Find a test case with multibyte strings for Like filter handler
3 participants
@samdark @vjik @arogachev