Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple bug fixes #28

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Simple bug fixes #28

merged 2 commits into from
Nov 19, 2024

Conversation

schwesinger
Copy link

Here's another set of trivial fixes.

The first commit supersedes the patch from [1] as it was rebased onto main recently.

Fix a misspelled module name in an except-clause.

Signed-off-by: Folker Schwesinger <dev@folker-schwesinger.de>
Fix the initialization of instance variable _bmap_path by renaming
the only occurrence of _f_bmap_path in the constructor of class
BmapCopy.

The naming scheme (_f_bmap, _bmap_path) is now consistent with
(_f_dest, _dest_path) and (_f_image, _image_path) declared later in
the BmapCopy constructor.

Signed-off-by: Folker Schwesinger <dev@folker-schwesinger.de>
@schwesinger
Copy link
Author

Gentle ping @twoerner @moto-timo @JPEWdev

@JPEWdev
Copy link
Collaborator

JPEWdev commented Nov 19, 2024

Our CI is pretty broken at the moment, but I manually verified this change

@JPEWdev JPEWdev merged commit 83fcea5 into yoctoproject:main Nov 19, 2024
1 of 6 checks passed
@schwesinger schwesinger deleted the simple-bug-fixes branch January 20, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants