Respect query part of the url when operating on the path #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to use bmaptool, with artifacts from gitlab CI which have a ?job=... query parameter at the end of the URL: - ignore the query part of the URL when determining the compression type - ignore the query part of the URL when computing the basename and stripping off the filename extension - first strip off and then re-apply the query part of the URL when adding the .bmap extension to the path
josch
changed the title
|
For the record, we are now using a patched bmaptool in our Debian derivative for the MNT Reform open hardware laptop with this patch: https://source.mnt.re/reform/reform-debian-packages/-/blob/main/patches/bmap-tools That way, this change will get a bit more testing in the wild compared to just sitting in a pull request. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to use bmaptool, with artifacts from gitlab CI which have a
?job=...query parameter at the end of the URL: