Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support finding non-namespaced resources stuck by finalizers #419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yuni-sa
Copy link
Contributor

@Yuni-sa Yuni-sa commented Mar 5, 2025

What this PR does / why we need it?

Currently we only check for namespaced resources with finalizers.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

GitHub Issue

Closes #418

Notes for your reviewers

also updated output format.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 43.52%. Comparing base (5cfae3f) to head (680266d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/kor/finalizers.go 0.00% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   43.61%   43.52%   -0.09%     
==========================================
  Files          63       65       +2     
  Lines        4074     4204     +130     
==========================================
+ Hits         1777     1830      +53     
- Misses       2049     2116      +67     
- Partials      248      258      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yuni-sa Yuni-sa force-pushed the support-non-namespaced-finalizers branch from 9794a6a to 680266d Compare March 9, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: non-namespaced resources with finalizers
2 participants