Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PR template file #3049

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add a PR template file #3049

merged 1 commit into from
Jan 14, 2025

Conversation

Gekko0114
Copy link
Contributor

In this PR, I've added a PR template file.

@Gekko0114
Copy link
Contributor Author

Hi @utam0k @YJDoc2
I've added a PR template because it would be helpful when creating a new PR.
Please review this PR when you have time!

@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 13, 2025
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, couple of comments

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me except for nits by YJDoc2.

@Gekko0114
Copy link
Contributor Author

@utam0k @YJDoc2
Thanks, I've updated the template based on @YJDoc2's comment

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k
Copy link
Member

utam0k commented Jan 14, 2025

Signed-off-by: moriya <41197469+Gekko0114@users.noreply.github.com>
@Gekko0114
Copy link
Contributor Author

Oh every time I forget signed-off... Thanks!

@utam0k utam0k merged commit 72784e2 into youki-dev:main Jan 14, 2025
27 checks passed
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
YamasouA pushed a commit to YamasouA/youki that referenced this pull request Feb 2, 2025
Signed-off-by: moriya <41197469+Gekko0114@users.noreply.github.com>
Signed-off-by: Akiyama <akiakiskyhand@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants