Skip to content

Commit

Permalink
fix: remove component getters (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
yoyopokki authored Jun 29, 2022
1 parent 114a2d7 commit 245e9b6
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 19 deletions.
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
<body>
<div id="root"></div>

<script type="module" src="/src/main.ts"></script>
<script type="module" src="/src/stand.ts"></script>
</body>
</html>
8 changes: 1 addition & 7 deletions src/main.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
import GenerationPlov from '@/generation-plov';
import Header from '@/test-components/header';

new GenerationPlov(
GenerationPlov.elementFactory(Header, {}, []),
document.getElementById('root')
);

export default {};
export default GenerationPlov;
9 changes: 9 additions & 0 deletions src/stand.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import GenerationPlov from '@/generation-plov';
import Header from '@/test-components/header';

new GenerationPlov(
GenerationPlov.elementFactory(Header, {}, []),
document.getElementById('root')
);

export default {};
11 changes: 0 additions & 11 deletions src/virtual-dom/nodes/virtual-dom-element-node.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import { AnyComponent } from '@/component/types';
import { VirtualDomNode, VirtualDomNodeChild } from '../types';

class VirtualDomElementNode implements VirtualDomNode {
private _key = Symbol('virtual-dom-element-key');

private _component: isNullable<AnyComponent> = null;

constructor(
private _tagName: string,
private _props: StringObject,
Expand All @@ -16,14 +13,6 @@ class VirtualDomElementNode implements VirtualDomNode {
return this._key;
}

public get component() {
return this._component;
}

public set component(value: isNullable<AnyComponent>) {
this._component = value;
}

public get tagName() {
return this._tagName;
}
Expand Down

0 comments on commit 245e9b6

Please sign in to comment.