Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message: add has_any_attribute() #25

Merged
merged 1 commit into from
Oct 10, 2024
Merged

message: add has_any_attribute() #25

merged 1 commit into from
Oct 10, 2024

Conversation

ystreet
Copy link
Owner

@ystreet ystreet commented Oct 10, 2024

Checks for multiple attributes at once. Improves performance by roughly 20% when adding multiple attributes to a message.

Checks for multiple attributes at once. Improves performance by roughly
20% when adding multiple attributes to a message.
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 20 lines in your changes missing coverage. Please review.

Project coverage is 84.46%. Comparing base (f03c3db) to head (f701b0b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
stun-types/src/message.rs 55.55% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   84.32%   84.46%   +0.13%     
==========================================
  Files          19       19              
  Lines        1563     1577      +14     
==========================================
+ Hits         1318     1332      +14     
  Misses        245      245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ystreet ystreet merged commit 9b9be62 into main Oct 10, 2024
9 of 10 checks passed
@ystreet ystreet deleted the has-any-attributes branch October 10, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant