Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny missing docs and debug implementation on public symbols #29

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

ystreet
Copy link
Owner

@ystreet ystreet commented Nov 18, 2024

commit ed0dcb5

attribute: require Attributes be Sync

Allows users to transfer &AttributeWrite (and MessageBuilder) across thread
boundaries.

commit cbd0a25

deny missing documentation and implement missing docs

commit f2382dd

message: bubble up attribute writing errors to the caller.

commit 3fde949

attribute/error: fix typo in error constant

commit 0b501e2

ensure types expose a debug implementation

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (a772f7b) to head (eca5c91).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          19       19           
  Lines        1596     1596           
=======================================
  Hits         1398     1398           
  Misses        198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ystreet ystreet force-pushed the deny-missing-docs-debug branch from d33c2d4 to eca5c91 Compare November 18, 2024 13:08
@ystreet ystreet merged commit de0c4ef into main Nov 18, 2024
10 checks passed
@ystreet ystreet deleted the deny-missing-docs-debug branch November 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant