Merge pull request #345 from yungifez/analysis-4w6DOe

Apply fixes from StyleCI
yungifez · Aug 4, 2023 · 93e3fba · 93e3fba
2 parents 85ea1b7 + f295237
commit 93e3fba
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/Services/AcademicYear/AcademicYearService.php b/app/Services/AcademicYear/AcademicYearService.php
@@ -86,10 +86,10 @@ public function setAcademicYear($academicYearId, $schoolId = null): bool
         $school = $this->schoolService->getSchoolById($schoolId);
         $school->academic_year_id = $academicYearId;
         //set semester id to first semester or null
-        $school->semester_id = $academicYear->semesters?->first()->id ?? ($school->academicYear->semesters()->create([
-            'name' => 'First',
+        $school->semester_id = $academicYear->semesters?->first()->id ?? $school->academicYear->semesters()->create([
+            'name'      => 'First',
             'school_id' => auth()->user()->school_id,
-        ]))->id;
+        ])->id;
 
         return $school->save();
     }