Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update from Hosted Weblate #1556

Closed
wants to merge 3 commits into from

Conversation

weblate
Copy link
Contributor

@weblate weblate commented Sep 5, 2024

Translations update from Hosted Weblate for InnerTune/App.

It also includes following components:

Current translation status:

Weblate translation status

@lucasmz-dev
Copy link
Contributor

lucasmz-dev commented Sep 5, 2024

Don't merge this ATM

@weblate weblate force-pushed the weblate-innertune-android branch 6 times, most recently from 746518b to 7aa05f6 Compare September 5, 2024 03:12
This was referenced Sep 5, 2024
@weblate weblate force-pushed the weblate-innertune-android branch 3 times, most recently from 7c87b5b to 9911bae Compare September 5, 2024 03:41
@lucasmz-dev
Copy link
Contributor

Hmm it seems we're getting warnings about missing plurals

Seems related to WeblateOrg/weblate#7520

@weblate weblate force-pushed the weblate-innertune-android branch 5 times, most recently from 1ceb3ae to 60e80b0 Compare September 5, 2024 04:35
@lucasmz-dev
Copy link
Contributor

Well I solved that issue by not letting Weblate update unneeded files, and not having the plugin to remove translations to no longer existinting strings/strings that don't exist in the original file; I think if I had just built it it would've worked just fine, but the linter complains for these languages for some reason

@weblate weblate force-pushed the weblate-innertune-android branch from 60e80b0 to 11e839a Compare September 5, 2024 05:45
@lucasmz-dev
Copy link
Contributor

lucasmz-dev commented Sep 5, 2024

Can be merged if you want at this point
But you can wait around until before a release

@weblate weblate force-pushed the weblate-innertune-android branch 7 times, most recently from cc32659 to ac091c7 Compare September 7, 2024 17:09
@weblate weblate force-pushed the weblate-innertune-android branch 3 times, most recently from 183f8ed to 32f2059 Compare September 8, 2024 11:59
@lucasmz-dev
Copy link
Contributor

(you can use github's squash and merge here if you prefer to keep this under one commit, it's a bit spammy right now)

@lucasmz-dev
Copy link
Contributor

it's just linting breaking, building works
not sure how to deal with this 😞

@weblate weblate force-pushed the weblate-innertune-android branch 6 times, most recently from 40df00c to 3cf2d4b Compare September 9, 2024 05:45
@lucasmz-dev
Copy link
Contributor

#1573 *

@weblate weblate force-pushed the weblate-innertune-android branch from 3414649 to 6ddcabe Compare September 10, 2024 08:33
@lucasmz-dev
Copy link
Contributor

@z-huang can you close this one? (don't merge)

@z-huang z-huang closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants