Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gpu): refactor negate to keep track of degree and noise changes #2022

Merged
merged 2 commits into from
Feb 3, 2025
Merged

chore(gpu): refactor negate to keep track of degree and noise changes #2022

merged 2 commits into from
Feb 3, 2025

Conversation

pdroalves
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@pdroalves pdroalves requested a review from agnesLeroy January 31, 2025 16:58
@cla-bot cla-bot bot added the cla-signed label Jan 31, 2025
agnesLeroy
agnesLeroy reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pdroalves! The PR looks great, I only have one question. Thanks a lot for it 🙂

backends/tfhe-cuda-backend/cuda/src/integer/div_rem.cuh Show resolved Hide resolved
@pdroalves pdroalves force-pushed the pa/chore/negate_degree_noise branch from 48efe1b to 756512e Compare January 31, 2025 17:31
@pdroalves pdroalves force-pushed the pa/chore/negate_degree_noise branch from 756512e to bc5ff1a Compare January 31, 2025 17:40
@pdroalves pdroalves changed the base branch from main to pa/fix/radix_test_typo January 31, 2025 17:41
Base automatically changed from pa/fix/radix_test_typo to main January 31, 2025 21:45
@pdroalves pdroalves force-pushed the pa/chore/negate_degree_noise branch from bc5ff1a to e3aa179 Compare February 3, 2025 12:02
@pdroalves pdroalves requested a review from agnesLeroy February 3, 2025 13:27
@agnesLeroy
Copy link
Contributor

Thank you! 🙏

@agnesLeroy agnesLeroy merged commit 88ec12a into main Feb 3, 2025
146 checks passed
@agnesLeroy agnesLeroy deleted the pa/chore/negate_degree_noise branch February 3, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnesLeroy agnesLeroy agnesLeroy approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdroalves @agnesLeroy @zama-bot