-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split optional dependencies in pyproject.toml #309
Merged
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6d87930
split optional deps
TomNicholas 5b14477
comment out un-implemented readers
TomNicholas 850c38a
remove _reader suffix
TomNicholas aeecf8a
add kerchunk as writer to cover fastparquet dependency
TomNicholas e1df506
Merge branch 'main' into split_optional_deps
TomNicholas a633a0c
embed the pyproject.toml in the installation docs
TomNicholas 4d77fa1
notes on test and docs deps
TomNicholas 32966e5
wording
TomNicholas aa34761
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cc8a218
release note
TomNicholas b4cfe5c
Merge branch 'main' into split_optional_deps
TomNicholas 28cbb03
Merge branch 'main' into split_optional_deps
TomNicholas 2cbcd2f
update kerchunk version
TomNicholas af52c4c
separate remote options
TomNicholas 65c4af1
remove sneaky git thing
TomNicholas a81a845
Update pyproject.toml
TomNicholas a34843b
update kerchunk verion
TomNicholas d79e348
remove commented-out readers
TomNicholas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commented-out lines are going to appear in the docs - https://virtualizarr--309.org.readthedocs.build/en/309/installation.html#optional-dependencies.
Should I (a) remove them or (b) add issue links to encourage people to contribute those readers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove them because I don't think it's a certainty that those readers will be built based on kerchunk and its dependencies. e.g., I have it on my roadmap for the next 2 months to implement a reader based on https://github.com/developmentseed/aiocogeo-rs/.