Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group param to virtualize Dataset accessor #391

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add group param to virtualize Dataset accessor #391

merged 1 commit into from
Jan 27, 2025

Conversation

chuckwondo
Copy link
Contributor

@chuckwondo chuckwondo commented Jan 27, 2025 •
edited
Loading

Add optional group kw-only parameter to the to_icechunk method of the "virtualize" xr.Dataset custom accessor.

@chuckwondo chuckwondo mentioned this pull request Jan 27, 2025
Closed
maxrjones
maxrjones approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chuckwondo!

@maxrjones maxrjones merged commit e8ade46 into zarr-developers:main Jan 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrjones maxrjones maxrjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_icechunk doesn't have a group option
2 participants
@chuckwondo @maxrjones