Skip to content

Commit

Permalink
Skip ABS testing on Python 3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
joshmoore committed Feb 15, 2024
1 parent 822dbe3 commit 43e6aaf
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,17 @@ jobs:
shell: "bash -l {0}"
env:
COVERAGE_FILE: .coverage.${{matrix.python-version}}.${{matrix.numpy_version}}
ZARR_TEST_ABS: 1
ZARR_TEST_MONGO: 1
ZARR_TEST_REDIS: 1
ZARR_V3_EXPERIMENTAL_API: 1
ZARR_V3_SHARDING: 1
run: |
# Skip ABS on 3.9, see https://github.com/zarr-developers/zarr-python/pull/1542/#issuecomment-1945557365 etc.
if [[ "${{ matrix.python-version }}" == '3.9' ]]; then
echo "ZARR_TEST_ABS=0" >> "$GITHUB_ENV"
else
echo "ZARR_TEST_ABS=1" >> "$GITHUB_ENV"
fi
conda activate zarr-env
mkdir ~/blob_emulator
azurite -l ~/blob_emulator --debug debug.log 2>&1 > stdouterr.log &
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/windows-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: True
matrix:
python-version: ['3.10', '3.11']
python-version: ['3.9', '3.10', '3.11']
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -45,12 +45,17 @@ jobs:
- name: Run Tests
shell: bash -l {0}
run: |
# Skip ABS on 3.9, see https://github.com/zarr-developers/zarr-python/pull/1542/#issuecomment-1945557365 etc.
if [[ "${{ matrix.python-version }}" == '3.9' ]]; then
echo "ZARR_TEST_ABS=0" >> "$GITHUB_ENV"
else
echo "ZARR_TEST_ABS=1" >> "$GITHUB_ENV"
fi
conda activate zarr-env
mkdir ~/blob_emulator
azurite -l ~/blob_emulator --debug debug.log 2>&1 > stdouterr.log &
pytest -sv --timeout=300
env:
ZARR_TEST_ABS: 1
ZARR_V3_EXPERIMENTAL_API: 1
ZARR_V3_SHARDING: 1
- name: Conda info
Expand Down

0 comments on commit 43e6aaf

Please sign in to comment.