-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 reorg #1809
V3 reorg #1809
Conversation
SQLiteStore, | ||
TempStore, | ||
ZipStore, | ||
from __future__ import annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is showing up as a line-edit diff but no edits were made. I first moved the original __init__.py
-> v2/__init__.py
, then made a commit. Then the v3/__init__.py
file was moved here in a second commit.
@@ -36,8 +34,7 @@ def test_storage(self): | |||
d = json.loads(str(store[attrs_key], "utf-8")) | |||
assert dict(foo="bar", baz=42) == d | |||
|
|||
def test_utf8_encoding(self): | |||
project_root = pathlib.Path(zarr.__file__).resolve().parent.parent | |||
def test_utf8_encoding(self, project_root): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an actual change, although not a very consequential one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check every change, but the general direction looks good and if there's any rough edges we can iron those out later.
A pretty uninformed question, please take it with a grain of salt, but would keeping the main directories and aliasing into the main namespace be more forward compatible? (i.e., avoid the need to move everything back to v3 when/if v4 comes along) |
Imo, the |
This PR moves the v3 source code to the project root and preserves the v2 sources in a new
v2
directory.Process taken:
Step 1: move all v2 sources and tests to v2 directories, update imports and tests, commit -> ee09dec
Stepo 2: move all v3 sources from v3 directory to zarr root, update imports, tests, docs, and pyproject.toml, commit -> 51780ed
TODO: