-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Ruff to apply flake8-bugbear/isort/pyupgrade #1864
Conversation
…nto chore/ruff-isort-v3b
Why "apply ruff formatting" in this pull request? As far as I can tell, this project is currently using zarr-python/.pre-commit-config.yaml Lines 14 to 17 in cb4230d
|
@DimitriPapadopoulos - this PR is pointing at the |
That's right. BTW, I know you've been working on this topic here in Zarr land for a while. Now that I see your PRs against the V3 branch, I'm happy to step aside and let you run that to completion. Would you like me to close this PR? |
"docs" | ||
"docs", | ||
"src/zarr/v2/", | ||
"tests/v2/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this exclusion didn't seem to work. I'll rerun.
This is likely to cause some serious merge conflicts with #1857 - I'm going to hold on this until that has been merged. Hopefully tomorrow 🐎 . |
@@ -615,7 +619,7 @@ def _shard_index_size(self, chunks_per_shard: ChunkCoords) -> int: | |||
16 * product(chunks_per_shard), self._get_index_chunk_spec(chunks_per_shard) | |||
) | |||
|
|||
@lru_cache | |||
@lru_cache # noqa: B019 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know! Fixed in 530e88b
Closing in favor of #1890 |
Fixes #1841
Closes #1862
TODO: