Make typing strict #1879
Merged
Make typing strict #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
v3-strict-typing
branch
2 times, most recently
from
6bf7fa1 to
31f649d
Compare
|
@dstansby - let us know when this is ready for a review. |
dstansby
force-pushed
the
v3-strict-typing
branch
from
31f649d to
08ddbab
Compare
dstansby
force-pushed
the
v3-strict-typing
branch
from
2b5e384 to
132a65d
Compare
|
👍 should be good to review now |
jhamman
approved these changes
Jun 1, 2024
| @@ -18,6 +18,6 @@ | |||
|
|
|||
| def parse_indexing_order(data: Any) -> Literal["C", "F"]: | |||
There was a problem hiding this comment.
noting that this function also exists in zarr.common... No need to fix here but we don't need both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables strict mypy typing, fixing (almost) #1783 🎉
TODO: