Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable extra mypy error codes #1909

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Enable extra mypy error codes #1909

merged 4 commits into from
Jun 1, 2024

Conversation

dstansby
Copy link
Contributor

Enable extra mypy error codes. Another part of #1783

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dstansby dstansby mentioned this pull request May 24, 2024
Closed
16 tasks
@dstansby dstansby changed the title Clean up v2 mypy ignores Enable extra mypy error codes May 24, 2024
@dstansby dstansby force-pushed the mypy-error-codes branch from cb230c4 to e337a55 Compare May 31, 2024 22:06
@jhamman jhamman merged commit b4cdf94 into zarr-developers:v3 Jun 1, 2024
18 checks passed
@dstansby dstansby deleted the mypy-error-codes branch June 1, 2024 09:20
@jhamman jhamman added this to the 3.0.0.alpha milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
types
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @jhamman