Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slow queries on some environments #1524

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

tpluscode
Copy link
Collaborator

We may later understand why the repeated subqueries are so inefficient on TEST. For now, we can remove that problem by creating the computed values in memory

@tpluscode tpluscode requested a review from giacomociti June 7, 2024 09:47
Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: 07e7149

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (cfdb26d) to head (07e7149).

Files Patch % Lines
...hared-dimensions/lib/handlers/shared-dimensions.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   73.50%   73.51%   +0.01%     
==========================================
  Files         219      219              
  Lines       14880    14889       +9     
  Branches      849      850       +1     
==========================================
+ Hits        10937    10946       +9     
  Misses       3934     3934              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode tpluscode merged commit b82ebab into master Jun 11, 2024
19 checks passed
@tpluscode tpluscode deleted the shared-dimension-query branch June 11, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants