Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opendata.swiss resources #1533

Merged
merged 11 commits into from
Sep 24, 2024
Merged

opendata.swiss resources #1533

merged 11 commits into from
Sep 24, 2024

Conversation

tpluscode
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 4ba35b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cube-creator/ui Patch
@cube-creator/core-api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.59%. Comparing base (aa9a922) to head (4ba35b3).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1533   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files         219      219           
  Lines       14892    14892           
  Branches      850      839   -11     
=======================================
  Hits        11109    11109           
  Misses       3780     3780           
  Partials        3        3           
Flag Coverage Δ
74.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

${skos.prefLabel} ?name ;
${skos.inScheme} <http://publications.europa.eu/resource/authority/file-type> .

FILTER(regex(?name, "_q_", "i"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the filter? in TEST,it filters out all values

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a template. Does _q_ instead of {q} to prevent URL encoding an gets replaced later.

From the UI, the value of q is provided from the auto-complete editor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, is there a way to test the UI locally? It relies on the presence of the https://lindas.admin.ch/ontologies graph

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The queries go against PUBLIC_QUERY_ENDPOINT.

You can add PUBLIC_QUERY_ENDPOINT=https://test.lindas.admin.ch/query to .env in project root and then lando rebuild

@tpluscode tpluscode merged commit 11082f2 into master Sep 24, 2024
23 checks passed
@tpluscode tpluscode deleted the ods-resources branch September 24, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants