Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Dimensions: searching and paging #1565

Merged
merged 17 commits into from
Feb 11, 2025
Merged

Shared Dimensions: searching and paging #1565

merged 17 commits into from
Feb 11, 2025

Conversation

tpluscode
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 871c2db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cube-creator/ui Minor
@cube-creator/shared-dimensions-api Minor
@cube-creator/core-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 47.67442% with 90 lines in your changes missing coverage. Please review.

Project coverage is 73.69%. Comparing base (3e4acc3) to head (871c2db).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
apis/shared-dimensions/lib/shapeToQuery.ts 60.86% 27 Missing ⚠️
...s/shared-dimensions/lib/shapes/shared-dimension.ts 13.63% 19 Missing ⚠️
...hared-dimensions/lib/handlers/shared-dimensions.ts 0.00% 17 Missing ⚠️
apis/shared-dimensions/lib/handlers/collection.ts 0.00% 15 Missing ⚠️
apis/shared-dimensions/lib/domain/hierarchies.ts 0.00% 10 Missing ⚠️
apis/shared-dimensions/lib/handlers/hierarchies.ts 0.00% 1 Missing ⚠️
apis/shared-dimensions/lib/handlers/hierarchy.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
- Coverage   73.90%   73.69%   -0.21%     
==========================================
  Files         222      222              
  Lines       15252    15357     +105     
  Branches      899      901       +2     
==========================================
+ Hits        11272    11318      +46     
- Misses       3972     4031      +59     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode tpluscode merged commit d884e6d into master Feb 11, 2025
21 of 23 checks passed
@tpluscode tpluscode deleted the dim-search branch February 11, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants