ClimbingGradesTable: Add climbing grades table #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The chips are not clear enough they are togglable.. Maybe with the little (x) it should be clearer. Also maybe the dialog should be fixed (min)width, now it is little jumpy. Maybe also smaller fixed width columns could help. One idea - you can use
One bug - the icons are too close to the text:
|
This will be refactored here: #767 |
jvaclavik
force-pushed
the
add-climbing-grades-table
branch
from
1bd9233 to
be85fd3
Compare
jvaclavik
force-pushed
the
add-climbing-grades-table
branch
2 times, most recently
from
fd15fbd to
61d219d
Compare
jvaclavik
force-pushed
the
add-climbing-grades-table
branch
from
61d219d to
26625a3
Compare
jvaclavik
force-pushed
the
add-climbing-grades-table
branch
from
26625a3 to
41aec74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example links
Screenshots
Checklist
resolves #741