Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Climbing: Open selected photo from climbing area #855

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/FeaturePanel/Climbing/ClimbingView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,8 @@ export const ClimbingView = ({ photo }: { photo?: string }) => {
Object.keys(resolutions).filter((key) => resolutions[key] === true).length >
0;

console.log('___// loadedPhotos', loadedPhotos);

const replacePhotoIfNeeded = (photos: string[], selectedIndex: number) => {
if (!photos.includes(photoPath) && selectedIndex > -1 && !isPhotoLoading) {
if (photos.length > 0) {
Expand Down
4 changes: 4 additions & 0 deletions src/components/FeaturePanel/Climbing/Editor/RoutesEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ export const RoutesEditor = ({
...loadedPhotos,
[photoPath]: { ...loadedPhotos[photoPath], [photoResolution]: true },
});
console.log('___ setLoadedPhotos', {
...loadedPhotos,
[photoPath]: { ...loadedPhotos[photoPath], [photoResolution]: true },
});
loadPhotoRelatedData();
preloadOtherPhotos();
setIsPhotoLoading(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export const RouteList = ({ isEditable }: { isEditable?: boolean }) => {
};
}, [routeSelectedIndex, routes, routeIndexExpanded]); // eslint-disable-line react-hooks/exhaustive-deps

console.log('___routes', routes);
return (
<Container>
{routes.length !== 0 && <RouteListDndContent isEditable={isEditable} />}
Expand Down
12 changes: 9 additions & 3 deletions src/components/FeaturePanel/CragsInArea.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { getInstantImage } from '../../services/images/getImageDefs';
import { intl } from '../../services/intl';
import Link from 'next/link';
import { naturalSort } from './Climbing/utils/array';
import { handleClimbingDialogOnClick } from './FeatureImages/Image/helpers';

const ArrowIcon = styled(ArrowForwardIosIcon)`
opacity: 0.2;
Expand Down Expand Up @@ -101,12 +102,17 @@ const Header = ({
</HeadingRow>
);

const Gallery = ({ images }) => {
const Gallery = ({ images, feature }) => {
return (
<Wrapper>
<Slider>
{naturalSort(images, (item) => item.def.k).map((item) => (
<Image key={item.image.imageUrl} def={item.def} image={item.image} />
<Image
key={item.image.imageUrl}
def={item.def}
image={item.image}
onClick={handleClimbingDialogOnClick(feature, item.def)}
/>
))}
</Slider>
</Wrapper>
Expand Down Expand Up @@ -143,7 +149,7 @@ const CragItem = ({ feature }: { feature: Feature }) => {
routesCount={feature.members?.length}
imagesCount={images.length}
/>
{images.length ? <Gallery images={images} /> : null}
{images.length ? <Gallery feature={feature} images={images} /> : null}
</Container>
</StyledLink>
);
Expand Down
10 changes: 9 additions & 1 deletion src/components/FeaturePanel/FeatureImages/FeatureImages.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { useLoadImages } from './useLoadImages';
import { NoImage } from './NoImage';
import { HEIGHT, ImageSkeleton } from './helpers';
import { naturalSort } from '../Climbing/utils/array';
import { handleClimbingDialogOnClick } from './Image/helpers';
import { useFeatureContext } from '../../utils/FeatureContext';

export const Wrapper = styled.div`
width: 100%;
Expand All @@ -32,6 +34,7 @@ export const Slider = ({ children }) => (

export const FeatureImages = () => {
const { loading, images } = useLoadImages();
const { feature } = useFeatureContext();
if (images.length === 0) {
return <Wrapper>{loading ? <ImageSkeleton /> : <NoImage />}</Wrapper>;
}
Expand All @@ -40,7 +43,12 @@ export const FeatureImages = () => {
<Wrapper>
<Slider>
{naturalSort(images, (item) => item.def.k).map((item) => (
<Image key={item.image.imageUrl} def={item.def} image={item.image} />
<Image
key={item.image.imageUrl}
def={item.def}
image={item.image}
onClick={handleClimbingDialogOnClick(feature, item.def)}
/>
))}
</Slider>
</Wrapper>
Expand Down
21 changes: 12 additions & 9 deletions src/components/FeaturePanel/FeatureImages/Image/Image.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,7 @@ import {
import { PathsSvg } from '../PathsSvg';

import { HEIGHT } from '../helpers';
import {
initialSize,
UncertainCover,
useGetOnClick,
useImgSizeOnload,
} from './helpers';
import { initialSize, UncertainCover, useImgSizeOnload } from './helpers';
import { PanoramaImg } from './PanoramaImg';
import { InfoButton } from './InfoButton';
import { ImageDef, isTag } from '../../../../services/types';
Expand Down Expand Up @@ -61,18 +56,26 @@ const ImageWrapper = styled.div<{ $hasPaths: boolean }>`
type Props = {
def: ImageDef;
image: ImageType;
onClick: (def: ImageDef) => void;
};

export const Image = ({ def, image }: Props) => {
export const Image = ({ def, image, onClick }: Props) => {
const { imgRef, size, onPhotoLoad } = useImgSizeOnload();
const onClick = useGetOnClick(def);

const hasPaths =
isTag(def) && !!(def.path?.length || def.memberPaths?.length);

const isImageLoaded = size !== initialSize;
const showInfo = image.panoramaUrl || isImageLoaded;
return (
<ImageWrapper $hasPaths={hasPaths} onClick={onClick}>
<ImageWrapper
$hasPaths={hasPaths}
onClick={(e) => {
onClick(def);
e.stopPropagation();
e.preventDefault();
}}
>
{image.panoramaUrl ? (
<PanoramaImg small={image.imageUrl} large={image.panoramaUrl} />
) : (
Expand Down
5 changes: 2 additions & 3 deletions src/components/FeaturePanel/FeatureImages/Image/helpers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,12 @@ export const UncertainCover = styled.div`
box-shadow: inset 0 0 100px rgba(255, 255, 255, 0.3);
`;

export const useGetOnClick = (def: ImageDef) => {
const { feature } = useFeatureContext();

export const handleClimbingDialogOnClick = (feature, def: ImageDef) => {
if (isTag(def) && feature.tags.climbing === 'crag') {
return () => {
const featureLink = getOsmappLink(feature);
const photoLink = removeFilePrefix(def.v);
console.log('___', `${featureLink}/climbing/photo/${photoLink}`);
Router.push(`${featureLink}/climbing/photo/${photoLink}`);
};
}
Expand Down
Loading