Skip to content

Commit

Permalink
Fix uploads to edit_events table (#8318)
Browse files Browse the repository at this point in the history
This PR fixes uploads the `edit_events` table.

We were trying to insert into a column that didn't exist:

```
HTTP error 500 Internal Server Error: failed to upload to table 'edit_events'

Caused by:
    bad response: Code: 16. DB::Exception: No such column os_name in table default.edit_events
```

Release Notes:

- N/A
  • Loading branch information
maxdeviant authored Feb 24, 2024
1 parent 622cae1 commit 7599933
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions crates/collab/src/api/events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -703,11 +703,6 @@ pub struct EditEventRow {
patch: Option<i32>,
release_channel: String,

// SystemInfoBase
os_name: String,
os_version: Option<String>,
architecture: String,

// ClientEventBase
installation_id: Option<String>,
// Note: This column name has a typo in the ClickHouse table.
Expand Down Expand Up @@ -742,9 +737,6 @@ impl EditEventRow {
minor: semver.map(|s| s.minor as i32),
patch: semver.map(|s| s.patch as i32),
release_channel: body.release_channel.clone().unwrap_or_default(),
os_name: body.os_name.clone(),
os_version: body.os_version.clone(),
architecture: body.architecture.clone(),
installation_id: body.installation_id.clone(),
session_id: body.session_id.clone(),
is_staff: body.is_staff,
Expand Down

0 comments on commit 7599933

Please sign in to comment.