Skip to content

Commit

Permalink
Add ssh initialization events (#18831)
Browse files Browse the repository at this point in the history
Release Notes:

- N/A
  • Loading branch information
JosephTLyons authored Oct 7, 2024
1 parent 5387a6f commit a15b109
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 4 deletions.
6 changes: 3 additions & 3 deletions crates/client/src/telemetry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ impl Telemetry {
worktree_id: WorktreeId,
updated_entries_set: &UpdatedEntriesSet,
) {
let project_names: Vec<String> = {
let project_type_names: Vec<String> = {
let mut state = self.state.lock();
state
.worktree_id_map
Expand Down Expand Up @@ -521,8 +521,8 @@ impl Telemetry {
};

// Done on purpose to avoid calling `self.state.lock()` multiple times
for project_name in project_names {
self.report_app_event(format!("open {} project", project_name));
for project_type_name in project_type_names {
self.report_app_event(format!("open {} project", project_type_name));
}
}

Expand Down
17 changes: 16 additions & 1 deletion crates/recent_projects/src/dev_servers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,13 @@ impl DevServerProjects {
match connection.await {
Some(_) => this
.update(&mut cx, |this, cx| {
let _ = this.workspace.update(cx, |workspace, _| {
workspace
.client()
.telemetry()
.report_app_event("create ssh server".to_string())
});

this.add_ssh_server(connection_options, cx);
this.mode = Mode::Default(None);
cx.notify()
Expand Down Expand Up @@ -422,7 +429,15 @@ impl DevServerProjects {
);

cx.new_view(|cx| {
Workspace::new(None, project.clone(), app_state.clone(), cx)
let workspace =
Workspace::new(None, project.clone(), app_state.clone(), cx);

workspace
.client()
.telemetry()
.report_app_event("create ssh project".to_string());

workspace
})
})
.log_err();
Expand Down
6 changes: 6 additions & 0 deletions crates/workspace/src/workspace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5575,6 +5575,12 @@ pub fn open_ssh_project(
cx.replace_root_view(|cx| {
let mut workspace =
Workspace::new(Some(workspace_id), project, app_state.clone(), cx);

workspace
.client()
.telemetry()
.report_app_event("open ssh project".to_string());

workspace.set_serialized_ssh_project(serialized_ssh_project);
workspace
});
Expand Down
2 changes: 2 additions & 0 deletions crates/zed/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,8 @@ fn main() {
session_id,
cx,
);

// We should rename these in the future to `first app open`, `first app open for release channel`, and `app open`
if let (Some(system_id), Some(installation_id)) = (&system_id, &installation_id) {
match (&system_id, &installation_id) {
(IdType::New(_), IdType::New(_)) => {
Expand Down

0 comments on commit a15b109

Please sign in to comment.