Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project panel works with large delays in large projects #23025

Closed
caoyang2002 opened this issue Jan 12, 2025 · 10 comments
Closed

Project panel works with large delays in large projects #23025

caoyang2002 opened this issue Jan 12, 2025 · 10 comments
Assignees
Labels
large projects For anything relating to large volumes of files or multiple subprojects in one main project. performance Feedback for performance issues, speed, memory usage, etc project panel Feedback for files tree view

Comments

@caoyang2002
Copy link

caoyang2002 commented Jan 12, 2025

Describe the bug / provide steps to reproduce it

image

I create a file, and all the content in the right sidebar disappears. I have to reopen Zed to restore the display.

Zed Version and System Specs

Darwin MacBookPro.lan 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 18:40:14 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T8103 arm64

Zed 0.168.2 – /Applications/Zed.app

@caoyang2002 caoyang2002 added admin read bug [core label] labels Jan 12, 2025
@SomeoneToIgnore
Copy link
Contributor

Can you paste screenshot of what's been in the right sidebar before creating the file?

@SomeoneToIgnore SomeoneToIgnore added the awaiting info Issue that needs more information from the user label Jan 12, 2025
@caoyang2002
Copy link
Author

Now it can't display anymore. I've already restarted the computer, but it still doesn't show. As a demonstration, I can only open it in VS Code.

vscode

image

zed

image

@SomeoneToIgnore
Copy link
Contributor

Sorry, it's very hard for me to understand what is a "right sidebar" on VSCode too — there, I see a left dock open, and the editor in the center (with the minimap).
Nothing on the right side of VSCode is present too?

@caoyang2002
Copy link
Author

caoyang2002 commented Jan 12, 2025

Sorry, I described it wrong. It's the left side, the area that displays the file directory.

image

After using zed . to open this project and waiting for a long time, the file directory finally appeared. Before that, it couldn’t display.

image

but, it cannot open files. I tried to open the README, but it was not displayed in the window.

@SomeoneToIgnore SomeoneToIgnore changed the title The file directory on the right disappears occasionally The file directory in the project panel disappears occasionally Jan 12, 2025
@SomeoneToIgnore SomeoneToIgnore removed the awaiting info Issue that needs more information from the user label Jan 12, 2025
@SomeoneToIgnore
Copy link
Contributor

Finally, it starts to make sense.

One last question: is it a lot of files in the project?

I suspect that Zed's project panel is scanning the entire project at once before showing anything, as does it so slow that nothing appears there for a while.

@caoyang2002
Copy link
Author

caoyang2002 commented Jan 12, 2025

Yes,more than 60,000 files.

I just closed this project and tried to reopen it. It's been ten minutes now, and the project panel is still empty.

@SomeoneToIgnore SomeoneToIgnore changed the title The file directory in the project panel disappears occasionally Project panel works with large delays in large projects Jan 12, 2025
@JosephTLyons JosephTLyons added performance Feedback for performance issues, speed, memory usage, etc project panel Feedback for files tree view large projects For anything relating to large volumes of files or multiple subprojects in one main project. and removed triage labels Jan 24, 2025
@JosephTLyons
Copy link
Collaborator

CC - @osiewicz (AKA, the performance goat).

@osiewicz
Copy link
Contributor

osiewicz commented Jan 24, 2025

This can be observed on rust-lang/rust as well; it has to do with this call:

.status(&[git::WORK_DIRECTORY_REPO_PATH.clone()])

I'm not sure what we can do about it at the moment, sans maybe decoupiling git scan from the main background scan.
/cc @cole-miller

SomeoneToIgnore added a commit that referenced this issue Feb 5, 2025
Part of #24099
Part of #23025

Git status checks & updates are still slow for such repos, but those are
now not blocking FS entry population and rescans.

Release Notes:

- Improved project panel's speed in large projects
@SomeoneToIgnore
Copy link
Contributor

#24307 had been merged and I see much faster project panel interactions in chromium repo.
Git status updates are still painfully slow, but at least asynchronous now.

If you can build from source and give it a try, or wait until next Preview version to release with it.

@notpeter notpeter removed the bug [core label] label Feb 14, 2025
@SomeoneToIgnore
Copy link
Contributor

After #24722 I am not able to reproduce this, so closing optimistically.
Please comment or create another issue if things in large projects continue to be delayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large projects For anything relating to large volumes of files or multiple subprojects in one main project. performance Feedback for performance issues, speed, memory usage, etc project panel Feedback for files tree view
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants