-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move git status updates to a background thread #24307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d35ee0b
to
85f4a33
Compare
Wait for the git status fetch to complete before propagating the new snapshot and status data.
This was referenced Feb 6, 2025
cole-miller
added a commit
that referenced
this pull request
Feb 7, 2025
This reverts commit 980ce5f.
cole-miller
added a commit
that referenced
this pull request
Feb 7, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 7, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 8, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 10, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 11, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 11, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 12, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 12, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 12, 2025
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 14, 2025
Follow-up of #24307 Brings back the PR and fixes the issue with the git status not propagated, if computed too slow. Now, git repo update * waits in the background for all `scan_dir` repo status updates and triggers another status update send afterwards * ensures that the update sent is reported correctly (`scanning = true`) if either FS or status scan is running still * during worktree's git statuses updates, bumps `status_scan_id` to ensure the repo update is reported to all subscribers Release Notes: - Improved project panel's speed in large projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24099
Part of #23025
Git status checks & updates are still slow for such repos, but those are now not blocking FS entry population and rescans.
Release Notes: