Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move git status updates to a background thread #2 #24722

Merged
merged 6 commits into from
Feb 14, 2025

Conversation

SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Feb 12, 2025

Follow-up of #24307

Brings back the PR and fixes the issue with the git status not propagated, if computed too slow.
Now, git repo update

  • waits in the background for all scan_dir repo status updates and triggers another status update send afterwards
  • ensures that the update sent is reported correctly (scanning = true) if either FS or status scan is running still
  • during worktree's git statuses updates, bumps status_scan_id to ensure the repo update is reported to all subscribers

Release Notes:

  • Improved project panel's speed in large projects

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 12, 2025
@SomeoneToIgnore SomeoneToIgnore force-pushed the kb/background-git branch 4 times, most recently from 9e27275 to 2379346 Compare February 12, 2025 23:25
…4415)

This reverts commit 5ffacb9.

# Conflicts:
#	crates/worktree/src/worktree.rs

# Conflicts:
#	crates/worktree/src/worktree.rs

# Conflicts:
#	crates/worktree/src/worktree.rs
Now, background scan

* waits for all `scan_dir` repo status updates and triggers another status update send
* during worktree's git statuses updates, bumps `status_scan_id` to ensure the repo update is reported to all subscribers
@SomeoneToIgnore SomeoneToIgnore merged commit 744579e into main Feb 14, 2025
12 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/background-git branch February 14, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant