Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve Rust syntax highlighting (#25333)" #25460

Conversation

maxdeviant
Copy link
Member

@maxdeviant maxdeviant commented Feb 24, 2025

This reverts commit 3e75a66.

Categorizing all identifiers as @variable seems like too broad a brush to paint with.

While it doesn't make a difference in many themes, it does produce some stark changes in some of the base themes:

Zed Nightly Zed Preview
Gruvbox - Nightly Gruvbox - Preview
One Dark - Nightly One Dark - Preview

Release Notes:

@maxdeviant maxdeviant self-assigned this Feb 24, 2025
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 24, 2025
@maxdeviant
Copy link
Member Author

Closing in favor of #25464.

@maxdeviant maxdeviant closed this Feb 24, 2025
@maxdeviant maxdeviant deleted the marshall/revert-3e75a661dd6d5837b4c4b15f10b5fcfc19306beb branch February 24, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant