Restore re-rendering of editors on buffer font size changes #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
commented
Jan 16, 2024
| @@ -2761,6 +2761,8 @@ impl<'a, V: 'static> ViewContext<'a, V> { | |||
| .rendered_frame | |||
| .dispatch_tree | |||
| .view_path(self.view.entity_id()) | |||
| .into_iter() | |||
| .rev() | |||
There was a problem hiding this comment.
/cc @as-cii could you double check that this is correct? Without this, I think that if two views with common ancestors both call .notify(), the second one will bail out before pushing the Notify effect.
There was a problem hiding this comment.
That makes total sense, thanks for the fix!
SomeoneToIgnore
added a commit
that referenced
this pull request
Feb 23, 2025
Closes #25413 As the issue points out well, themes do not need to alter any in-memory state on load: that is done via settings file load. Originally, it was introduced in #4064 and #24857 had restored that behavior, which seems wrong to do. Apart from removing that part, removes unnecessary methods and emphasizes that in-memory state is the Buffer/UI size — no need to add `Adjusted` there as the settings file presence is already enough. Release Notes: - Fixed theme selector resetting the buffer size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that views are cached, we need to explicitly
.notify()text editors when the buffer font size changes.