-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpui: Support loading image from filesystem #6978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdeviant
reviewed
Jan 29, 2024
maxdeviant
reviewed
Jan 29, 2024
maxdeviant
reviewed
Jan 29, 2024
Thanks for the review, I cleaned up the example in the last commit. Still getting familiar with gpui 👍🏻 |
This looks great! Thank you for the addition :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for loading and displaying images from a local file using gpui's
img
element.API Changes:
SharedUrl
toSharedUrl::File
,SharedUrl::Network
Usage:
This will be useful when implementing markdown image support, because we need to be able to render images from the filesystem (relative/absolute path), e.g. when implementing markdown preview #5064.
I also added an example

image
to the gpui crate, let me know if this is useful. Showcase:Note: The example is fetching images from Lorem Picsum (Github Repo), which is a free resource for fetching images in a specific size. Please let me know if you're okay with using this in the example.