Improve mention visibility by adding a background color #7014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
RemcoSmitsDev
changed the title
maxbrunsfeld
requested changes
Jan 29, 2024
| Fill::default() | ||
| }) | ||
| .p_1() | ||
| .rounded_md() |
There was a problem hiding this comment.
Just curious - how does this look when two consecutive message both mention you?
There was a problem hiding this comment.
Haven't tested that one. We might want a little bit more margin in this case.
When there is a message in between, it looks nice:
There was a problem hiding this comment.
I changed it locally to this. But one note, this brings a little inconsistency with spacing between messages that do/not have a mention inside the message. It's not much, but I'm not sure if this is a problem.
There was a problem hiding this comment.
I fixed the inconsistent spacing issue in my latest commit.
|
Thanks @RemcoSmitsDev; this will ship in Zed 0.121. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the chat if going fast, It's hard to see who is mentioning you, so this feature will make it more clear by the UI instead of needing to read all the messages.
Release Notes: