Allow OpenAI API URL to be configured via assistant.openai_api_url
#7552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
assistant.openai_api_urlassistant.openai_api_url
maxdeviant
reviewed
Feb 8, 2024
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
|
@Yesterday17 Thank you! |
|
To maintain consistency set by OpenAI wrappers, I propose using the standard openai_base_url naming convention and if not yet introduced add ability to read it from env level. This will enhance maintainability and make our code more familiar for those using other OpenAI tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #4321, since Azure OpenAI API can be converted to OpenAI API.
Release Notes:
assistant.openai_api_urlsetting to allow OpenAI API URL to be configured.