-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Auto folded dirs performance issues #8556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the issue in is_foldable
and get this up to date with main, then we can merge it :)
Are there render tests anywhere such that we could add tests with pathologically long folded directory hierarchies, so we can monitor this for regressions? |
Thanks for fixing those issues @ABckh! I did some manual testing, and things are feeling smooth when switching tabs. I'm going to merge without the caching we where discussing earlier and see how it feels. That said, I also defaulted this new setting to |
Fixed auto folded dirs which caused significant performance issues #8476 (#7674)
Moved from iterating over snapshot entries to use
child_entries
function fromworktree.rs
by making it public@maxbrunsfeld
Release Notes:
project_panel.auto_fold_dirs
setting which collapses the nesting in the project panel when there is a chain of folders containing a single folder.