Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auto folded dirs performance issues #8556

Merged
merged 20 commits into from
Apr 12, 2024

Conversation

ABckh
Copy link
Contributor

@ABckh ABckh commented Feb 28, 2024

Fixed auto folded dirs which caused significant performance issues #8476 (#7674)

Moved from iterating over snapshot entries to use child_entries function from worktree.rs by making it public

@maxbrunsfeld

Release Notes:

  • Fixed a bug where project panel settings changes would not be applied immediately.
  • Added a project_panel.auto_fold_dirs setting which collapses the nesting in the project panel when there is a chain of folders containing a single folder.
Screenshot 2024-04-12 at 11 10 58 AM

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 28, 2024
Copy link
Member

@mikayla-maki mikayla-maki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the issue in is_foldable and get this up to date with main, then we can merge it :)

@ABckh ABckh requested a review from mikayla-maki March 28, 2024 22:06
@MrTact
Copy link

MrTact commented Apr 11, 2024

Are there render tests anywhere such that we could add tests with pathologically long folded directory hierarchies, so we can monitor this for regressions?

@mikayla-maki
Copy link
Member

mikayla-maki commented Apr 12, 2024

Thanks for fixing those issues @ABckh!

I did some manual testing, and things are feeling smooth when switching tabs. I'm going to merge without the caching we where discussing earlier and see how it feels.

That said, I also defaulted this new setting to false, as it seems to mainly be useful for Java.

@mikayla-maki mikayla-maki merged commit 8bca9ce into zed-industries:main Apr 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants