Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 0.63 PipelineRun version removed. #30

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Fix: 0.63 PipelineRun version removed. #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85ca717
fix: Extension now correctly detects if zenml is not installed.
Christopher-R-Perkins Jul 30, 2024
043c400
fix: Removed Pipeline Run Version for .63
Christopher-R-Perkins Jul 31, 2024
8ae4dfb
Merge branch 'develop' into fix/pipeline-run-api-change
strickvl Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundled/tool/lsp_zenml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ async def is_zenml_installed(self) -> bool:
process = await asyncio.create_subprocess_exec(
self.python_interpreter,
"-c",
"import zenml",
"import zenml; print(zenml.__version__)",
stdout=asyncio.subprocess.PIPE,
stderr=asyncio.subprocess.PIPE,
)
Expand Down
1 change: 0 additions & 1 deletion bundled/tool/zenml_grapher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,4 @@ def to_dict(self) -> GraphResponse:
"edges": self.edges,
"status": self.run.body.status,
"name": self.run.body.pipeline.name,
"version": self.run.body.pipeline.body.version,
}
5 changes: 1 addition & 4 deletions bundled/tool/zenml_wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,6 @@ def fetch_pipeline_runs(self, args):
"id": str(run.id),
"name": run.body.pipeline.name,
"status": run.body.status,
"version": run.body.pipeline.body.version,
"stackName": run.body.stack.name,
"startTime": (
run.metadata.start_time.isoformat()
Expand Down Expand Up @@ -396,7 +395,6 @@ def get_pipeline_run(self, args: Tuple[str]) -> dict:
"id": str(run.id),
"name": run.body.pipeline.name,
"status": run.body.status,
"version": run.body.pipeline.body.version,
"stackName": run.body.stack.name,
"startTime": (
run.metadata.start_time.isoformat()
Expand Down Expand Up @@ -434,7 +432,7 @@ def get_pipeline_run_graph(
"""
try:
run_id = args[0]
run = self.client.get_pipeline_run(run_id, hydrate=True)
run = self.client.get_pipeline_run(run_id)
graph = Grapher(run)
graph.build_nodes_from_steps()
graph.build_edges_from_steps()
Expand Down Expand Up @@ -485,7 +483,6 @@ def get_run_step(self, args: Tuple[str]) -> Union[RunStepResponse, ErrorResponse
"pipeline": {
"name": run.body.pipeline.name,
"status": run.body.status,
"version": run.body.pipeline.body.version,
},
"cacheKey": step.metadata.cache_key,
"sourceCode": step.metadata.source_code,
Expand Down
2 changes: 1 addition & 1 deletion src/commands/pipelines/DagRender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export default class DagRenderer extends WebviewBase {
const graph = this.layoutDag(dagData);
const svg = await this.drawDag(graph);
const updateButton = dagData.status === 'running' || dagData.status === 'initializing';
const title = `${dagData.name} - v${dagData.version}`;
const title = `${dagData.name}`;

// And set its HTML content
panel.webview.html = this.getWebviewContent({
Expand Down
2 changes: 0 additions & 2 deletions src/types/PipelineTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export interface PipelineRun {
id: string;
name: string;
status: string;
version: string;
stackName: string;
startTime: string;
endTime: string;
Expand Down Expand Up @@ -67,7 +66,6 @@ export interface PipelineRunDag {
edges: Array<DagEdge>;
status: string;
name: string;
version: string;
}

export type PipelineRunsResponse = PipelineRunsData | ErrorMessageResponse | VersionMismatchError;
2 changes: 1 addition & 1 deletion src/views/activityBar/pipelineView/PipelineTreeItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class PipelineTreeItem extends vscode.TreeItem {
: vscode.TreeItemCollapsibleState.Collapsed
);
this.tooltip = `${run.name} - Status: ${run.status}`;
this.description = `version: ${run.version}, status: ${run.status}`;
this.description = `status: ${run.status}`;
this.iconPath = new vscode.ThemeIcon(PIPELINE_RUN_STATUS_ICONS[run.status]);
this.children = children;
}
Expand Down
Loading