Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Two Factor Authentication (2FA) #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

allenpigar
Copy link
Contributor

No description provided.

@allenpigar allenpigar requested a review from shrunyan November 16, 2022 13:06
@allenpigar allenpigar linked an issue Nov 16, 2022 that may be closed by this pull request
@allenpigar allenpigar marked this pull request as ready for review November 16, 2022 13:06
@shrunyan
Copy link
Contributor

What is the purpose of having verify2FaAuto and verify2Fa?
Why do the functions require a bearer token? There would be no session at this point in the login flow.

@allenpigar
Copy link
Contributor Author

Hi @shrunyan , verify2FaAuto and verify2Fa are function for checking if MFA token are verified once the two-factor authentication is enable during login.
if the user tried to login with two-factor authentication is enabled, they will receive this response,
image

MFA Flow

  1. Login account using credentials email and password.
  2. if account requires 2FA, notification will be sent from authy app for confirmation.
  3. verify token. Either provide mfa token from authy or approve the login request from the app.
    • use verify2Fa(session_token, mfa_token) to manually validate session token and mfa token.
    • verify2FaAuto(session_token) doesnt require mfa token from the app but need to keep on firing until the user approves the login request from the app.
  4. if verified, continue login

@shrunyan
Copy link
Contributor

How will verify2FaAuto keep firing? Is it expected that the consumer of the function manages the continually calling until the MFA is verified?

@allenpigar
Copy link
Contributor Author

Yes, user must provide the logic to manage the continues firing of the function. this implementation is same used as accounts login.

image

@shrunyan
Copy link
Contributor

shrunyan commented Dec 1, 2022

If the "auto" nature of the process is implemented by the sdk consumer I do not see why we would need two variations of this function. i.e. the verify2fa and verify2faAuto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add: MFA
2 participants