Add missing sortedSet commands and update ZRange command #1065
Conversation
| * @return | ||
| * A list of members in the specified range with, optionally, their scores when the WITHSCORES option is given. | ||
| */ | ||
| final def zRange[K: Schema]( |
There was a problem hiding this comment.
Since we're adding 7.x API, maybe we should remove the old zRange function and all "deprecated" functions (or at least "implement" them in terms of zRange and mark as deprecated)? WDYT?
There was a problem hiding this comment.
@mijicd Ok I deprecated the methods and implemented then in terms of the new zRange command, but CI/CD is failing because of the use of deprecated methods 🤔 How do I fix that ?
There was a problem hiding this comment.
I think the only way to fix that (and keep the deprecation notes) is to live up to our suggestions, a.k.a. update affected calls to new zRange. Alternatively, we could live with ignoring warnings, but that's just postponing the previous approach.
There was a problem hiding this comment.
Sorry, do you mean changing every call to use the new zRange and delete the deprecated methods ?
There was a problem hiding this comment.
Just change the calls in tests, don't delete.
Closes #999
Implement missing SortedSets commands and update ZRange command.