style: lint fuzz projects in CI #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bogay
commented
Jan 24, 2025
auto-merge was automatically disabled
February 14, 2025 18:18
Head branch was pushed to by a user without write access
Bogay
force-pushed
the
feat/lint-fuzz-projs-in-ci
branch
from
df9deaf to
cb89e86
Compare
|
The CI was failed for build on macos 1 and I could see similar fails in other PR 2. Today I noticed there are some successful runs for the same job 3 4 which should be irrelevant about this issue. Although I am not very sure the root cause about these fails but I think it's not related to the changes of this RP. @Pr0methean can you approve the workflows again? I guess CI should pass now. p.s. I just pushed some changes because I wanted to see if I could trigger CI again, but it seems I can't. Footnotes |
Pr0methean
changed the title
Pr0methean
previously approved these changes
Feb 25, 2025
|
Approved; this will be added to the merge queue if the fuzz checks pass. |
it seems that they depends on cargo-afl, so we need to use `cargo afl clippy` instead of `cargo clippy`.
In this commit I replaced `self.path.join("/")` with
`self.path.join("")` because I think the expected result should be
the original path with trailing "/".
see: https://rust-lang.github.io/rust-clippy/master/index.html#join_absolute_paths
auto-merge was automatically disabled
February 27, 2025 12:24
Head branch was pushed to by a user without write access
Bogay
force-pushed
the
feat/lint-fuzz-projs-in-ci
branch
from
802fa76 to
a018d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds steps to run
cargo fmtandcargo clippytofuzz_writeandfuzz_read, also fixed some issues found byfmtandclippy.