Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #298

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Update CI #298

merged 2 commits into from
Feb 26, 2025

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Feb 25, 2025

Our CI uses pretty outdated actions and generates a lot of warnings. Get rid of them and use commands directly.

@Pr0methean
Copy link
Member

See also #299 and rust-fuzz/afl.rs#590.

Pr0methean
Pr0methean previously approved these changes Feb 25, 2025
Copy link
Member

@Pr0methean Pr0methean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge once we have a fix or workaround for rust-fuzz/afl.rs#590.

@Pr0methean
Copy link
Member

Pr0methean commented Feb 25, 2025

If you decide to try to work around that bug, you'll probably need to start by updating cargo-afl to 0.15.15, although that alone didn't help when I tried it.

Nvm, that update is already pushed to master, and I've confirmed that the existing CI run used it.

@Pr0methean
Copy link
Member

Pr0methean commented Feb 26, 2025

Update: on my machine I managed to get the fuzz command working by removing the -a binary flag. It appears to still be loading the input corpus (which is indeed in binary format, but the input dictionary is in text format), since in the TUI "Corpus" is smaller than "Own finds" by about the number of files in the input corpus.

Worked on my machine

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
@Pr0methean Pr0methean enabled auto-merge February 26, 2025 00:39
@Pr0methean Pr0methean added this pull request to the merge queue Feb 26, 2025
Merged via the queue into zip-rs:master with commit 3e78ee1 Feb 26, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants