chore: change keccak256 to precompiled keccak in revme #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plz update the example in project-template too. https://github.com/zkMIPS/zkm-project-template/tree/main/guest-program/revme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization helps reduce the size of the tables, which are the total cells we commit. Therefore, it reduces the total proving time.
Here are the metrics before this opt:
As you can see, the total number of committed cells is up to 2*10^8 and the proving time is ~ 170s
After this optimization, the number of committed cells decreases to ~ 1.5 * 10^8 ( 25% reduction ), and the proving is reduced to 143s
