Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: convert trace data to table #215

Merged
merged 7 commits into from
Jan 13, 2025
Merged

opt: convert trace data to table #215

merged 7 commits into from
Jan 13, 2025

Conversation

felicityin
Copy link
Contributor

@felicityin felicityin commented Jan 12, 2025 •
edited
Loading

System Parameters:

  • Number of Physical CPUs: 1
  • Number of Cores per Physical CPU: 8
  • Number of Logical CPUs: 16
  • Memory: 64 GB

Test:

cd zkm/prover/examples/revme/host
RUST_LOG=debug JSON_PATH=../../../../emulator/test-vectors/test.json SEG_OUTPUT=/tmp/output SEG_SIZE=26214400 cargo run --release

Results:

generate_traces() time-consuming / s into_tables() time-consuming / s
before optimization 4.4523 1.4494
4.5656 1.4886
4.4732 1.4324
after optimization 4.3766 1.3742
4.3768 1.3095
4.2084 1.2438

@felicityin felicityin changed the title chore: refactor into_tables() opt: convert from trace data to table Jan 12, 2025
@felicityin felicityin changed the title opt: convert from trace data to table opt: convert trace data to table Jan 12, 2025
@eigmax eigmax merged commit bb9fb74 into zkMIPS:main Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigmax eigmax eigmax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felicityin @eigmax