fix: fix bug in keccak precompile. #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanhGer
force-pushed
the
fix/keccak-compile
branch
from
af4aa64 to
88fa634
Compare
VanhGer
changed the title
eigmax
approved these changes
Jan 14, 2025
weilzkm
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fixing: with the different inputs:
3123123121122121411231and3123123123123121411231, our precompile keccak outputs the same value3ee5ea8c59a705af94f3081a0754b00db02a9215b34364fd3a2bacd2a64ebf9c.After fixing: correct value. It now outputs the correct value. Verify the result using this website: https://emn178.github.io/online-tools/keccak_256.html