feat: add Sha256 precompile #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanhGer
force-pushed
the
sha256-syscall
branch
from
072ddfa to
02d59f1
Compare
VanhGer
force-pushed
the
sha256-syscall
branch
from
02d59f1 to
c241bc5
Compare
eigmax
reviewed
Feb 3, 2025
| let mut state_values = vec![]; | ||
|
|
||
| for i in 0..8 { | ||
| let addr = MemoryAddress::new(0, Segment::Code, h_ptr + i * 4); |
There was a problem hiding this comment.
Why use Segment::Code here?
The code segment is only used for loading program into memory.
There was a problem hiding this comment.
This is the implementation of Angel. I saw the same code in the generate_keccak function implementation.
VanhGer
force-pushed
the
sha256-syscall
branch
from
178644a to
1fe7734
Compare
eigmax
reviewed
Feb 4, 2025
|
|
||
| (row.temp1, row.carry_4) = wrapping_add(row.inter_3, row.w_i); | ||
|
|
||
| row.a_rr_2 = rotate_right(row.input_state[get_input_range(0)].try_into().unwrap(), 2); |
There was a problem hiding this comment.
Can we just keep track of row.input_state's [0..2], [2..13], [13..22], [22..256] ? This also means a_rr_13 is not necessary to be tracked by each row.
so we don't need input_state to be of size 256? this can significantly reduce the cells scale.
eigmax
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Issue 213: Support SHA256 precompile