Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add helper function for LDE calculation #12

Merged
merged 9 commits into from
Sep 13, 2024
Merged

feat: Add helper function for LDE calculation #12

merged 9 commits into from
Sep 13, 2024

Conversation

jaehunkim
Copy link
Contributor

This is part of the effort to break down various tasks implemented for FRI implementation into smaller PR.
The LDE test referenced here.

@jaehunkim jaehunkim self-assigned this Sep 4, 2024
Cargo.toml Outdated Show resolved Hide resolved
}

// change order of elements in domain
pub fn change_order_of_elements_in_domain<F: FftField>(elements: &[F]) -> Vec<F> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a multiplicative group of order 8:
Typically, the elements are ordered as g^0, g^1, g^2, g^3, ...
However, in Stone's method, they use two types of element ordering:
One is the normal ordering, and the other is where
elements are ordered as g^0, g^4, g^2, g^6, ...

@jaehunkim jaehunkim marked this pull request as ready for review September 9, 2024 08:07
Base automatically changed from dev-mont-fix to master September 11, 2024 09:55
Copy link
Contributor

@rot256 rot256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Turns out we don't need to fix anything in ark-ff.

Cargo.toml Outdated Show resolved Hide resolved
fri/src/lde.rs Outdated Show resolved Hide resolved
fri/src/lde.rs Outdated Show resolved Hide resolved
fri/src/stone_domain.rs Outdated Show resolved Hide resolved
fri/src/stone_domain.rs Outdated Show resolved Hide resolved
@jaehunkim jaehunkim merged commit a216925 into master Sep 13, 2024
2 checks passed
@jaehunkim jaehunkim deleted the dev-lde branch September 13, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants