Cross-LPAR copy fails when copying a LARGE format dataset #2420
Conversation
jace-roell
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2420 +/- ##
=======================================
Coverage 91.36% 91.37%
=======================================
Files 639 639
Lines 18283 18280 -3
Branches 3923 3920 -3
=======================================
- Hits 16704 16703 -1
+ Misses 1577 1575 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
jace-roell
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
pujal0909,
anaxceron and
ATorrise
|
📅 Suggested merge-by date: 2/12/2025 |
packages/zosfiles/CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| All notable changes to the Zowe z/OS files SDK package will be documented in this file. | |||
|
|
|||
| ## Recent Changes | |||
|
|
|||
| - BugFix: The `Create.dataSetValidateOptions()` function now handles creating data sets with a `dsorg` of `PS-L` by changing the `dsntype` to `LARGE` [#2141](https://github.com/zowe/zowe-cli/issues/2141) | |||
There was a problem hiding this comment.
- We should explain what
dsorganddsntypeare - Sentence needs to end w/ a period
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
...ges/cli/__tests__/zosfiles/__system__/create/pds/cli.files.create.dataset.pds.system.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: jace-roell <jace.roell@hotmail.com>
|
There was a problem hiding this comment.
LGTM, thanks @jace-roell!
Incidentally I find it weird the argument is named --dsntype rather than --dstype, but not requesting changes since it's been that way on other commands for a long time 🙂
zFernand0
added
release-minor
|
Apologies for going back and forth on the release labels. I noticed a comment about a possible breaking change in behavior in another PR
Got a bit confused, but I believe that even if we publish this as a minor, we can publish a patch soon if needed |
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Create.dataSetValidateOptions()SDK method--dsntypeflag to create sequential data set CLI commandHow to Test
zowe files create ps <sourceDataSet> --dsntype LARGERun the cross LPAR copy command on this newly created data set
zowe files copy dsclp <sourceDataSet> <targetDataSet> --target-zosmf-p <profile>Where
<profile>is the name of the profile for a remote LPAR (can be the same LPAR as the one being tested against)<sourceDataSet>is a data set which has adsorgofPS-L<targetDataSet>is the target location of the copied data setReview Checklist
I certify that I have:
Additional Comments - Possible future story
EXTREQOREXTPREFso it may be difficult to determine how the copied data set should be created based on only "PS-E" being returned.Results from Creating data sets and copying data sets cross LPAR with varying
dsntypes and their resultantextxattribute value:Created:
EXTREQCopy:
EXTREQSource DS extx: 1
Target DS extx: 1
Created:
EXTPREFCopy:
EXTPREFSource DS extx: 1
Target DS extx: 1
Created:
EXTPREFCopy:
EXTREQSource DS extx: 1
Target DS extx: 3
Created:
EXTREQCopy:
EXTPREFSource DS extx: 1
Target DS extx: 3